From fd5049b37fbdfd36c77552863bc1a968fc38bbe9 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 28 Feb 2014 21:15:06 +0100 Subject: [PATCH] mw.log.deprecate: Use mw.log.warn instead of log.warn In qunit/testrunner.js, freshConfigCopy() temporarily clears mw.log.warn to avoid a flood of spurious deprecation warnings. However, as of 89a8fe4, the console was once again flooded with deprecated notices when in debug mode because in debug mode we load mediawiki.log.js which redefines the mw.log object and as such the local reference here kept pointing to the original. Change-Id: I2b560aac9c0b929c82bb628760c194c0476fe1a9 --- resources/mediawiki/mediawiki.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js index 8b783707ee..bf5ad221bd 100644 --- a/resources/mediawiki/mediawiki.js +++ b/resources/mediawiki/mediawiki.js @@ -566,12 +566,12 @@ var mw = ( function ( $, undefined ) { enumerable: true, get: function () { mw.track( 'mw.deprecate', key ); - log.warn( msg ); + mw.log.warn( msg ); return val; }, set: function ( newVal ) { mw.track( 'mw.deprecate', key ); - log.warn( msg ); + mw.log.warn( msg ); val = newVal; } } ); -- 2.20.1